Alias assert_select methods to assert_dom versions #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bridge the gap between [rails#91][] (shipped) and [rails#92][] (open) by declaring [alias_method][] expressions for each `assert_select` variation, adding `assert_dom` variations to the interface. [rails#91]: rails#91 [rails#92]: rails#92 [alias_method]: https://docs.ruby-lang.org/en/3.0.0/Module.html#method-i-alias_method
|
@rafaelfranca I realized that |
|
That is fine. It is only used for local development. |
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Feb 19, 2021
On the heels of [rails/rails-dom-testing#91][] and [rails/rails-dom-testing#93][], and in preparation for [rails/rails-dom-testing#92][] [rails/rails-dom-testing#91]: rails/rails-dom-testing#91 [rails/rails-dom-testing#92]: rails/rails-dom-testing#92 [rails/rails-dom-testing#93]: rails/rails-dom-testing#93
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bridge the gap between #91 (shipped) and #92 (open) by declaring
alias_method expressions for each
assert_selectvariation, addingassert_domvariations to the interface.