Add method, index and FKs to help with clearing finished jobs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And preserve them by default. Also, add a new option to indicate when to delete preserved jobs.
packagethief
reviewed
Dec 6, 2023
|
|
||
| class_methods do | ||
| def clear_finished_in_batches(batch_size: 500, finished_before: SolidQueue.clear_finished_jobs_after.ago) | ||
| where(finished_at: ...finished_before).in_batches(of: batch_size, &:delete_all) |
There was a problem hiding this comment.
Small tip: you can call delete_all directly on the batch enumerator:
in_batches(of: batch_size).delete_allhttps://api.rubyonrails.org/classes/ActiveRecord/Batches/BatchEnumerator.html#method-i-delete_all
There was a problem hiding this comment.
Oh, nice! Definitely reads nicer! 🙏
rosa
force-pushed
the
clear-finished-jobs
branch
from
0443fc7 to
f1a6319
Compare
…time The foreign keys with cascade delete are just a failsafe, to ensure we don't fail to clear executions after deleting jobs.
rosa
force-pushed
the
clear-finished-jobs
branch
from
f1a6319 to
ec3fde0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #44, and it flips the setting to delete jobs to
preserve_finished_jobs, which istrueby default, so jobs will be kept by default instead. It also adds a new setting to indicate how long preserved jobs should be kept and a method to make the task of clearing finished jobs easier.This also adds some foreign keys in the execution tables, that might help as a failsafe, to ensure that no executions are left behind when jobs are deleted.