Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set successfully_enqueued for jobs enqueued in batch and return enqueued count #96

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Set successfully_enqueued for jobs enqueued in batch and return enqueued count #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/models/solid_queue/job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@ def enqueue_all(active_jobs)
prepare_all_for_execution(jobs).tap do |enqueued_jobs|
enqueued_jobs.each do |enqueued_job|
active_jobs_by_job_id[enqueued_job.active_job_id].provider_job_id = enqueued_job.id
active_jobs_by_job_id[enqueued_job.active_job_id].successfully_enqueued = true
end
end
end

active_jobs.count(&:successfully_enqueued?)
end

def enqueue(active_job, scheduled_at: Time.current)
Expand Down
1 change: 1 addition & 0 deletions test/models/solid_queue/job_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ class NonOverlappingGroupedJob2 < NonOverlappingJob

jobs = SolidQueue::Job.last(9)
assert_equal active_jobs.map(&:provider_job_id).sort, jobs.pluck(:id).sort
assert active_jobs.all?(&:successfully_enqueued?)
end

test "block jobs when concurrency limits are reached" do
Expand Down