Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent alias logical paths passed to asset_path #244

Merged
merged 2 commits into from
May 7, 2015
Merged

Prevent alias logical paths passed to asset_path #244

merged 2 commits into from
May 7, 2015

Conversation

josh
Copy link
Contributor

@josh josh commented May 6, 2015

Cherry pick #241 into 2.x.

/cc @rafaelfranca

@josh
Copy link
Contributor Author

josh commented May 6, 2015

@rafaelfranca if this looks good, are you cool with pushing this out in a new 2.x release?

rafaelfranca added a commit that referenced this pull request May 7, 2015
@rafaelfranca
Merge pull request #244 from rails/detect-asset-alias
f5a5c1d 
Prevent alias logical paths passed to asset_path
@rafaelfranca rafaelfranca merged commit f5a5c1d into 2.x May 7, 2015
@rafaelfranca rafaelfranca deleted the detect-asset-alias branch May 7, 2015 17:14
@rafaelfranca
Copy link
Member

Yeah, it is fine.

@matt-glover
Copy link

Seems that this change (or an extremely similar one) was reverted for the 3.x line here.

Should the 2.x line receive a revert also?

@aprescott
Copy link

@matt-glover interesting. I'm certainly in favour of reverting this change for 2.x if it helps address all the problems described in #241 in relation rails/sprockets#36. I think that's causing problems for us with foo vs foo/index.js. I was hoping to upgrade to Sprockets 3.x to try and resolve the matter, but sadly I'm blocked on haml_coffee_assets being locked on ~> 2.0.

rafaelfranca added a commit that referenced this pull request Jun 22, 2015
@rafaelfranca
Revert #244
7bad463 
See #251
@aprescott
Copy link

@matt-glover looks like it was backported and released in 2.3.2. #257

@matt-glover
Copy link

Looks great. This revert eliminated the spurious errors we were getting in development mode with the asset debug configuration enabled.

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josh @rafaelfranca @matt-glover @aprescott