Fix Ruby 2.7 deprecation in helper.rb #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
gabebw
added a commit
to hotline-webring/hotline-webring
that referenced
this pull request
Jul 2, 2020
We need this PR to prevent warnings from Ruby 2.7: rails/sprockets-rails#454 However, the last sprockets-rails release was in 2017, so we grab it from GitHub. It's pinned to the earliest ref that includes that PR so that we don't always grab the latest master (which is a shifting target and could introduce instability).
gabebw
added a commit
to hotline-webring/hotline-webring
that referenced
this pull request
Jul 2, 2020
We need this PR to prevent warnings from Ruby 2.7: rails/sprockets-rails#454 However, the last sprockets-rails release was in 2017, so we grab it from GitHub. It's pinned to the earliest ref that includes that PR so that we don't always grab the latest master (which is a shifting target and could introduce instability).
gabebw
added a commit
to hotline-webring/hotline-webring
that referenced
this pull request
Jul 2, 2020
We need this PR to prevent warnings from Ruby 2.7: rails/sprockets-rails#454 However, the last sprockets-rails release was in 2017, so we grab it from GitHub. It's pinned to the earliest ref that includes that PR so that we don't always grab the latest master (which is a shifting target and could introduce instability).
|
Would it be possible to have a new release of this gem so we do not need to install from git to get this Ruby 2.7 fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sibling PR to rails/sprockets#660. This needs to be changed to fix sprockets-rails causing a deprecation warning after the sprockets deprecation warning is fixed.
I've tested this on my Rails app and my test suite passes just fine with this change even if the sprockets change isn't present.
Oddly, this may actually be the only change that's necessary. I don't see any deprecation warning anymore with just this PR, regardless of whether the sprockets change is made or not.