Don't require ActionView::Base when rake tasks get loaded: #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
force-pushed
the
ec-action-view-noneed-toload
branch
2 times, most recently
from
1b26227 to
7e53408
Compare
- ### Problem When running any rake command, Sprockets Rails will autoload `ActionView::Base` way too early. This creates a broader issue which I described in detail in rails/rails#38024 ### Solution This `require` statement was the last attempt to fix a old [issue](rails/rails#9461) in 2014. TL;DR on the issue is that assets_prefix would get ignored when precompiling assets. A lot has change since 2014 in sprockets-rails and after digging I can confirm that requiring AV::Base is no longer needed. We don't need it to run assets related rake tasks. This is thanks thanks of the decoupling between `Sprockets::Rails::Context` and `Sprockets::Rails::Helper` in rails@32a58f54
Edouard-chin
force-pushed
the
ec-action-view-noneed-toload
branch
from
7e53408 to
e780283
Compare
|
Build is red but it doesn't seem related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require ActionView::Base when rake tasks get loaded:
Problem
When running any rake command, Sprockets Rails will autoload
ActionView::Baseway too early. This creates a broader issuewhich I described in detail in Create Finisher initializer to warn for components used too early: rails#38024
Solution
This
requirestatement was the last attempt to fix a old issuein 2014. TL;DR on the issue is that assets_prefix would
get ignored when precompiling assets.
A lot has change since 2014 in sprockets-rails and after digging
I can confirm that requiring AV::Base is no longer needed.
We don't need it to run assets related rake tasks.
This is thanks thanks of the decoupling between
Sprockets::Rails::ContextandSprockets::Rails::Helperin 32a58f54
cc/ @rafaelfranca