Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose dependencies from AssetUrlProcessor #480

Merged
merged 1 commit into from
Nov 19, 2021
Merged

expose dependencies from AssetUrlProcessor #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sprockets/rails/asset_url_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def self.call(input)
context = input[:environment].context_class.new(input)
data = input[:data].gsub(REGEX) { |_match| "url(#{context.asset_path($1)})" }

{ data: data }
context.metadata.merge(data: data)
end
end
end
Expand Down
34 changes: 23 additions & 11 deletions test/test_asset_url_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,36 +4,48 @@

Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
class TestAssetUrlProcessor < Minitest::Test
FIXTURES_PATH = File.expand_path("../fixtures", __FILE__)

def setup
@env = Sprockets::Environment.new
@env.append_path FIXTURES_PATH
@env.context_class.class_eval do
def asset_path(path, options = {})
'image-hexcodegoeshere.png'
end
include ::Sprockets::Rails::Context
end
@env.context_class.digest_assets = true

@logo_digest = @env["logo.png"].etag
@logo_uri = @env["logo.png"].uri
end

def test_basic
input = { environment: @env, data: 'background: url(image.png);', filename: 'url2.css', metadata: {} }
input = { environment: @env, data: 'background: url(logo.png);', filename: 'url2.css', metadata: {} }
output = Sprockets::Rails::AssetUrlProcessor.call(input)
assert_equal({ data: "background: url(image-hexcodegoeshere.png);" }, output)
assert_equal("background: url(/logo-#{@logo_digest}.png);", output[:data])
end

def test_spaces
input = { environment: @env, data: 'background: url( image.png );', filename: 'url2.css', metadata: {} }
input = { environment: @env, data: 'background: url( logo.png );', filename: 'url2.css', metadata: {} }
output = Sprockets::Rails::AssetUrlProcessor.call(input)
assert_equal({ data: "background: url(image-hexcodegoeshere.png);" }, output)
assert_equal("background: url(/logo-#{@logo_digest}.png);", output[:data])
end

def test_single_quote
input = { environment: @env, data: "background: url('image.png');", filename: 'url2.css', metadata: {} }
input = { environment: @env, data: "background: url('logo.png');", filename: 'url2.css', metadata: {} }
output = Sprockets::Rails::AssetUrlProcessor.call(input)
assert_equal({ data: "background: url(image-hexcodegoeshere.png);" }, output)
assert_equal("background: url(/logo-#{@logo_digest}.png);", output[:data])
end

def test_double_quote
input = { environment: @env, data: 'background: url("image.png");', filename: 'url2.css', metadata: {} }
input = { environment: @env, data: 'background: url("logo.png");', filename: 'url2.css', metadata: {} }
output = Sprockets::Rails::AssetUrlProcessor.call(input)
assert_equal("background: url(/logo-#{@logo_digest}.png);", output[:data])
end

def test_dependencies_are_tracked
input = { environment: @env, data: 'background: url(logo.png);', filename: 'url2.css', metadata: {} }
output = Sprockets::Rails::AssetUrlProcessor.call(input)
assert_equal({ data: "background: url(image-hexcodegoeshere.png);" }, output)
assert_equal(1, output[:links].size)
assert_equal(@logo_uri, output[:links].first)
end
end