Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpacker:check_node
task is calculating nodejs version wrongThis PR replaces calculation to use
Gem::Version
instead ofversion.to_f
. Also rails is using patched version ofbackticks
which is not raising exception if the binary is not exists. More info can be found here: Object#` I've added a fix towebpacker:check_node
andwebpacker:check_yarn
to raiseErrno::ENOENT
if the version check failed with blank value. I'm not sure if we have to raise and rescue in case of patchedbackticks
inactive_support
, but I'm leaving it like this so it will work if the patch is removed.