Nested polymorphic association fix #2363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
field.associated_model_config returns an array, but abstract_model is in field
|
Seems like this is an overdue and quite easy merge, anything I'm missing @sferik ? |
|
We need RSpec tests for this to ensure this fix works properly. |
voyera
referenced
this pull request
in playtestcloud/rails_admin
Dec 8, 2015
Don't try to access abstract_model of Array.
patleb
added a commit
to o2web/rails_admin
that referenced
this pull request
Jan 11, 2016
|
Hi! Do you still need specs to merge this? |
|
#2110 is already in the master, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork fixes the issue mentionned here: #1338
I'm hoping it can be integrated in the current version of rails_admin.