Fixed: Pundit's AuthorizationNotPerformedError #2683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After setting up Pundit on a new application, Pundit's README says that I can ensure that every request is authorized:
However, as @Samy-Amar has identified in #2642, Pundit checks an instance variable (
@_pundit_policy_authorized
) as part of this process, and RailsAdmin's Pundit adapter does not set@_pundit_policy_authorized
.This PR sets
@_pundit_policy_authorized
, and uses some of the existing Pundit testing infrastructure to introduce aRailsAdmin::MainController
-level spec for Pundit authorization.