fix application_helper#bulk_menu for overriding abstract_model #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanboho
force-pushed
the
fix_wording_for
branch
4 times, most recently
from
001df29 to
495bf28
Compare
When using the helper method `bulk_menu` for a model that is not the current `@abstract_model` the helper incorrectly gets the wording for the instance variable instead of passing the passed variable through.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the helper method
bulk_menufor a model that is not the current@abstract_modelthe helper incorrectly gets the wording for the instancevariable instead of passing the passed variable through.