New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary Devise patch #3352

Merged

mshibuya merged 1 commit into railsadminteam:master from codealchemy:remove-devise-patch

Apr 3, 2021

Contributor

codealchemy commented Apr 2, 2021

Originally added in db06979, this matches what's upstream in Devise (which was added in heartcombo/devise@17ec0c0) so this patch appears to no longer be needed.


          Remove devise_patch

8f4ba1f

Originally added in railsadminteam@db06979, this matches what's upstream in Devise (https://github.com/heartcombo/devise/blob/e8e0c275999dd98150197cab03acb5509cb16b6a/lib/devise/failure_app.rb#L226-L228 - last updated in heartcombo/devise@17ec0c0) and appears to no longer be needed.

Contributor Author

codealchemy commented Apr 2, 2021 •

edited

Loading

Ruby 2.2 / Rails 5 failures appear to be from recent mimemagic updates (unrelated to this change, and happening on master as well).

mshibuya merged commit 8a0e25d into railsadminteam:master

Member

mshibuya commented Apr 3, 2021

Agreed, thanks!

codealchemy deleted the remove-devise-patch branch

April 5, 2021 05:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet