Remove capitalization helper #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in railsadminteam@7f10337, `#capitalize_first_letter` includes assumptions about letter order / casing for all strings, and may apply the wrong capitalization rules for some use cases (case-sensitive strings, different languages). Most of the use cases here are using translations, in which case the letter casing can / should be applied in the translations themselves. Other cases, such as rendering the value of `object_label_method`, will show the value as-is without transformation (as seen in the test updates). Cursory checks in the Dummy app show no changes to the UI. The [CSS property `text-transform`](https://www.w3schools.com/cssref/pr_text_text-transform.asp) offers an alternative to achieve the same outcome, giving users of this library a way of applying letter-case logic in [theme overrides](https://github.com/sferik/rails_admin/wiki/Theming-and-customization).
|
Makes sense, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in 7f10337,
#capitalize_first_letterincludes assumptions about letter order / casing for all strings, and may apply the wrong capitalization rules for some use cases / contexts (case-sensitive strings, different languages - related #2354, StackOverflow Q/A).Most of the use cases here are using translations, in which case the letter casing can / should be applied in the translations themselves. Other cases, such as rendering the value of
object_label_method, will show the value as-is without transformation (as seen in the test updates). Cursory checks in the Dummy app show no changes to the UI.My use case here involves the latter, where the object's label (case sensitive) in the breadcrumb navigation is capitalized and has led to some confusion.
The CSS property
text-transformoffers an alternative to achieve the same outcome, giving users of this library a way of applying letter-case logic in theme overrides.