Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add not like operator (does not contain) #3410

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

Quent1Pr
Copy link
Contributor

We would like to add negative search filters
In reference to #3393

@mshibuya
Copy link
Member

Thanks for the implementation, could you add some tests for this?

@Quent1Pr
Copy link
Contributor Author

Quent1Pr commented Nov 15, 2021

I can't manage to run local tests by following https://github.com/railsadminteam/rails_admin/blob/master/CONTRIBUTING.md#submitting-a-pull-request

Instead, I use these commands :

appraisal install
bundle exec appraisal rake test

@codealchemy
Copy link
Contributor

codealchemy commented Nov 15, 2021

Please rebase against the latest master to resolve CI issues (fixed in a042aeb)

@Quent1Pr
Copy link
Contributor Author

I add the fix. We already use the v2.x-stable in production and need this feature quickly, is it possible to stay on the 2.x-stable branch, waiting master to be stable ? In that way, we can already use our fork without breaking anything.

@mshibuya
Copy link
Member

A new feature should go into the master first, then it can be back-ported afterwards. Can you switch target to the master branch?

@Quent1Pr Quent1Pr changed the base branch from 2.x-stable to master November 16, 2021 10:53
@Quent1Pr
Copy link
Contributor Author

Ok I switch to master.
Should I create a specific PR for 2.x-stable ?

@coveralls
Copy link

coveralls commented Nov 16, 2021

Pull Request Test Coverage Report for Build 1470969481

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.654%

Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 9 80.0%
Totals Coverage Status
Change from base Build 1466452219: -0.2%
Covered Lines: 3632
Relevant Lines: 3797

💛 - Coveralls

@mshibuya
Copy link
Member

One more step, please resolve Prettier and RuboCop failures 🙏
https://github.com/railsadminteam/rails_admin/runs/4227675468?check_suite_focus=true
https://github.com/railsadminteam/rails_admin/runs/4227675326?check_suite_focus=true

Should I create a specific PR for 2.x-stable ?

I'd be glad if you can!

@mshibuya mshibuya merged commit f59b32d into railsadminteam:master Nov 18, 2021
@mshibuya
Copy link
Member

Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants