-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add not like operator (does not contain) #3410
Conversation
Thanks for the implementation, could you add some tests for this? |
795c099
to
8741938
Compare
I can't manage to run local tests by following https://github.com/railsadminteam/rails_admin/blob/master/CONTRIBUTING.md#submitting-a-pull-request Instead, I use these commands :
|
Please rebase against the latest |
8741938
to
e4bda78
Compare
I add the fix. We already use the v2.x-stable in production and need this feature quickly, is it possible to stay on the 2.x-stable branch, waiting master to be stable ? In that way, we can already use our fork without breaking anything. |
A new feature should go into the master first, then it can be back-ported afterwards. Can you switch target to the master branch? |
e4bda78
to
0a50a63
Compare
0a50a63
to
1ae9348
Compare
Ok I switch to master. |
Pull Request Test Coverage Report for Build 1470969481
💛 - Coveralls |
One more step, please resolve Prettier and RuboCop failures 🙏
I'd be glad if you can! |
1ae9348
to
09e29bb
Compare
Thanks for the contribution! 🎉 |
We would like to add negative search filters
In reference to #3393