Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for EOL Ruby 2.5 #3430

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Conversation

jdufresne
Copy link
Member

Ruby 2.5 went EOL 2021-03-31. It is no longer supported upstream and so
is not receiving bug fixes, including for security issues. Reduce the
testing resources on RailsAdmin.

https://www.ruby-lang.org/en/downloads/branches/

Dropping EOL Ruby versions allows the project to begin taking advantage
of newer syntax and library features.

TargetRubyVersion was removed from .rubocop.yml as this value is
determined automatically from the gemspec.

Ruby 2.5 went EOL 2021-03-31. It is no longer supported upstream and so
is not receiving bug fixes, including for security issues. Reduce the
testing resources on RailsAdmin.

https://www.ruby-lang.org/en/downloads/branches/

Dropping EOL Ruby versions allows the project to begin taking advantage
of newer syntax and library features.

TargetRubyVersion was removed from .rubocop.yml as this value is
determined automatically from the gemspec.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1512935100

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-4.9%) to 91.023%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/rails_admin/bootstrap-sass/sass_functions.rb 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
app/controllers/rails_admin/application_controller.rb 8 82.22%
Totals Coverage Status
Change from base Build 1512343422: -4.9%
Covered Lines: 3346
Relevant Lines: 3676

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 28, 2021

Coverage Status

Changes unknown
when pulling 9e1b24c on jdufresne:eol-ruby
into ** on railsadminteam:master**.

@mshibuya
Copy link
Member

mshibuya commented Nov 30, 2021

Though being not documented yet (when this discussion is settled I will do it soon), existing way of deciding supported version is:

  • Support 2 major version of Rails (e.g. RailsAdmin 3.x supports Rails 6.x and 7.x)
  • Support Ruby version which are allowed in the lowest Rails version (e.g. since Rails 6.0 supports Ruby >= 2.5, use >= 2.5 for RailsAdmin 3.x)

How do you think of keeping this approach or do you have a different opinion?

Dropping EOL Ruby versions allows the project to begin taking advantage of newer syntax and library features.

I really, really understand this point, but we need to think about existing users who can't upgrade their app easily.

@mshibuya mshibuya merged commit 01e4640 into railsadminteam:master Feb 5, 2022
@mshibuya
Copy link
Member

mshibuya commented Feb 5, 2022

Merging in, since I realized that to introduce Turbo Drive we need to drop support for Ruby 2.5.
Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants