-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JavaScript library jquery-pjax #3435
Conversation
The library is no longer maintained and has not received a new release since May 20, 2017. See https://github.com/defunkt/jquery-pjax > Status of this project > > jquery-pjax is largely unmaintained at this point. This also removes the Ruby gem rack-pjax which is also no longer maintained and has not received a new release since Mar 24, 2019. This is work towards the goal of dropping jQuery in favor of more vanilla JavaScript solutions. As a dependency using jQuery, pjax was a barrier toward this goal. jquery-pjax was originally introduced in 645d678 (Nov 16, 2011). Presumably as a page loading optimization, however it is not strictly necessary to achieve the set of RailsAdmin features. After many years of improvements in browser caching, loading, and JavaScript evaluation it is unclear if this optimization is still necessary for a good UX. Refs railsadminteam#2893
Pull Request Test Coverage Report for Build 1514239307
💛 - Coveralls |
Changes unknown |
This is understandable, but I'm not totally sure about it. It would be ideal if we can perform quantitative comparison... Another solution will be migrating to Turbo Drive, which I understand is modernized version of Pjax. |
* Remove JavaScript library jquery-pjax The library is no longer maintained and has not received a new release since May 20, 2017. See https://github.com/defunkt/jquery-pjax > Status of this project > > jquery-pjax is largely unmaintained at this point. This also removes the Ruby gem rack-pjax which is also no longer maintained and has not received a new release since Mar 24, 2019. This is work towards the goal of dropping jQuery in favor of more vanilla JavaScript solutions. As a dependency using jQuery, pjax was a barrier toward this goal. jquery-pjax was originally introduced in 645d678 (Nov 16, 2011). Presumably as a page loading optimization, however it is not strictly necessary to achieve the set of RailsAdmin features. After many years of improvements in browser caching, loading, and JavaScript evaluation it is unclear if this optimization is still necessary for a good UX. Refs #2893
Squash-merged with 44451f2, thanks! I'll try introducing Turbo Drive later. |
@jdufresne Sorry I failed to put your credit to the commit when I handled squash merge locally. |
No worries at all. Thanks for merging and for Rails admin in general! |
The library is no longer maintained and has not received a new release
since May 20, 2017. See https://github.com/defunkt/jquery-pjax
This also removes the Ruby gem rack-pjax which is also no longer
maintained and has not received a new release since Mar 24, 2019.
This is work towards the goal of dropping jQuery in favor of more
vanilla JavaScript solutions. As a dependency using jQuery, pjax was a
barrier toward this goal.
jquery-pjax was originally introduced in
645d678 (Nov 16, 2011). Presumably as a
page loading optimization, however it is not strictly necessary to
achieve the set of RailsAdmin features. After many years of improvements
in browser caching, loading, and JavaScript evaluation it is unclear if
this optimization is still necessary for a good UX.
Refs #2893