Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore full width for content #3493

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

q3aiml
Copy link
Contributor

@q3aiml q3aiml commented Mar 10, 2022

During the bootstrap 5 update in 6878670 (#3455) this class was changed from
content to container. The container class, unlike content, has a max
width of 1320px. Restore prior behavior of using the full width by using
container-fluid to avoid wasted whitespace. This is especially useful on
list pages with a large number of columns.

Before

before non-full width image

After

after full width image

Bootstrap 3

image

During the bootstrap 5 update in 6878670 (railsadminteam#3455) this class was changed from
`content` to `container`. The `container` class, unlike `content`, has a max
width of 1320px. Restore prior behavior of using the full width by using
`container-fluid` to avoid wasted whitespace.
@mshibuya mshibuya merged commit ebc834d into railsadminteam:master Mar 11, 2022
@mshibuya
Copy link
Member

Ah I didn't notice, thanks!

mshibuya pushed a commit that referenced this pull request Mar 13, 2022
During the bootstrap 5 update in 6878670 (#3455) this class was changed from
`content` to `container`. The `container` class, unlike `content`, has a max
width of 1320px. Restore prior behavior of using the full width by using
`container-fluid` to avoid wasted whitespace.
@q3aiml q3aiml deleted the full-width-content branch March 25, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants