Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor label classes to badges #3503

Merged

Conversation

fuegas
Copy link
Contributor

@fuegas fuegas commented Apr 4, 2022

From the migrations documentation of Bootstrap v4 -> v5:

  • Consolidated .label and .badge to disambiguate from the element and simplify related components.

This change refactors the usage of labels to their counterparts as badges. Namely the logout label/badge and the representation of booleans. These referenced the label classes which no longer exist.

The changes visually:

Logout label / badge:
Currently:
Screenshot 2022-04-04 at 14 52 35
After this change:
Screenshot 2022-04-04 at 14 52 52

Boolean representation:
Currently:
Screenshot 2022-04-04 at 14 56 17
After this change:
Screenshot 2022-04-04 at 14 56 37

@fuegas fuegas changed the title Refactor labels to badges Refactor label classes to badges Apr 4, 2022
@fuegas fuegas force-pushed the refactor-labels-to-badges branch from 29b5231 to 0d28e44 Compare April 4, 2022 13:03
From the migrations documentation of Bootstrap v4 -> v5:

> - Consolidated .label and .badge to disambiguate from the <label> element and simplify related components.

This change refactors the usage of labels to their counterparts as badges. Namely the logout label/badge and the representation of booleans. These referenced the label classes which no longer exist.
@fuegas fuegas force-pushed the refactor-labels-to-badges branch from 0d28e44 to 0248e5d Compare April 4, 2022 13:09
@coveralls
Copy link

coveralls commented Apr 4, 2022

Coverage Status

Changes unknown
when pulling 0248e5d on fuegas:refactor-labels-to-badges
into ** on railsadminteam:master**.

Copy link
Contributor

@codealchemy codealchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@codealchemy codealchemy merged commit 42d668f into railsadminteam:master Apr 5, 2022
@codealchemy
Copy link
Contributor

Thanks!

@fuegas fuegas deleted the refactor-labels-to-badges branch April 5, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants