Add whitespace after navigation icon #3504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed by mshibuya and codealchemy in [upgrade to Bootstrap v5](https://github.com/railsadminteam/rails_admin/pull/3455/files#r780533297) the rendering of icons should not be fixed with CSS but adding a whitespace between the icon and the text. This change applies that solution to the icons in the sidebar navigation as well.
mshibuya
reviewed
Apr 7, 2022
| @@ -94,7 +94,7 @@ def root_navigation | |||
| actions(:root).select(&:show_in_sidebar).group_by(&:sidebar_label).collect do |label, nodes| | |||
| li_stack = nodes.map do |node| | |||
| url = rails_admin.url_for(action: node.action_name, controller: 'rails_admin/main') | |||
| nav_icon = node.link_icon ? %(<i class="#{node.link_icon}"></i>).html_safe : '' | |||
| nav_icon = node.link_icon ? %(<i class="#{node.link_icon}"></i> ).html_safe : '' | |||
There was a problem hiding this comment.
We don't need this, since we have link_to nav_icon + " " + wording_for... just below this.
There was a problem hiding this comment.
Ah yes, I'll remove this change.
|
@mshibuya any update on the status of this PR? 😄 |
|
Sorry for delay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed by mshibuya and codealchemy in upgrade to Bootstrap v5 the rendering of icons should not be fixed with CSS but adding a whitespace between the icon and the text.
This change applies that solution to the icons in the sidebar navigation as well.