Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak select form fields class for filters #3559

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

codealchemy
Copy link
Contributor

Bootstrap 5 uses form-select (https://getbootstrap.com/docs/5.0/forms/select/) to help indicate the field is a dropdown.

Before

Capture d’écran 2022-10-27 à 13 54 24

After

Capture d’écran 2022-10-27 à 13 54 35

Bootstrap 5 uses `form-select` (https://getbootstrap.com/docs/5.0/forms/select/) to help indicate the field is a dropdown.
@coveralls
Copy link

coveralls commented Oct 27, 2022

Coverage Status

Coverage decreased (-0.03%) to 95.886% when pulling 85fe568 on codealchemy:fix-select-for-filters into 6042110 on railsadminteam:master.

@mshibuya mshibuya merged commit 4a8cc9e into railsadminteam:master Oct 28, 2022
@mshibuya
Copy link
Member

It looks better, thanks! 👍

jklimke pushed a commit to 3dcl/rails_admin that referenced this pull request Nov 8, 2022
* master:
  Version 3.1.0
  Fix to use defer instead of async to ensure script loading order
  Tweak `select` form fields class (railsadminteam#3559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants