Simplify uses of defined? #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an instance variable isn't defined it will always return nil.
tachyons
reviewed
Jan 6, 2023
| return @excluded if defined?(@excluded) | ||
|
|
||
| @excluded = !RailsAdmin::AbstractModel.all.collect(&:model_name).include?(abstract_model.try(:model_name)) | ||
| @excluded ||= !RailsAdmin::AbstractModel.all.collect(&:model_name).include?(abstract_model.try(:model_name)) |
There was a problem hiding this comment.
Is the behaviour change here intended? This change removes the benefit of memoisation when the result is falsely.
Ref: http://gavinmiller.io/2013/advanced-memoization-in-ruby/
There was a problem hiding this comment.
Good catch. No that is not intended. If you put up a PR I'll approve, otherwise I'll try to get to it later today.
There was a problem hiding this comment.
Restored in #3587. Thanks for reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an instance variable isn't defined it will always return nil.