Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace &rdquo; entity with inline <q> element #3636

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

jdufresne
Copy link
Member

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/q

Most modern browsers implement this by surrounding the text in
quotation marks.

Importantly, this uses the localized quotation glyph. In English, this is the same left/right quotation mark.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/q

> Most modern browsers implement this by surrounding the text in
> quotation marks.

Importantly, this uses the localized quotation glyph. In English, this
is the same left/right quotation mark.
@coveralls
Copy link

Coverage Status

coverage: 95.965% (+0.07%) from 95.892% when pulling 3db9f5d on jdufresne:q-element into da48004 on railsadminteam:master.

@codealchemy codealchemy merged commit d1859a8 into railsadminteam:master Jul 6, 2023
@codealchemy
Copy link
Contributor

Thanks!

jklimke added a commit to 3dcl/rails_admin that referenced this pull request Nov 28, 2023
* 'master' of github.com:railsadminteam/rails_admin:
  Tidy up gemfiles
  Bump jRuby
  Test against Mongoid 8
  Test against Rails 7.1
  Mitigate jRuby build failures
  Upgrade node and vite to fix the vite build
  Un-pin turbo-rails to fix Rails 6.1 builds
  Follow-up for railsadminteam#3555
  Resolved a problem with embedded mongoid documents and boolean selectors (railsadminteam#3555)
  Stop using update_only to decide to show subform on create (railsadminteam#3649)
  Follow-up for railsadminteam#3643
  Basic vite integration attempt (railsadminteam#3643)
  Support client-side dynamic scoping
  Fix Rubocop offense
  Revive the live demo
  Unlock webrick version
  Fix typo: tripple ==> triple (railsadminteam#3637)
  Replace &rdquo; entity with inline <q> element (railsadminteam#3636)
  Vulnerability fix: validate return_to param using request.host (railsadminteam#3627)
  Fix Rubocop offense
@jdufresne jdufresne deleted the q-element branch June 13, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants