Add ActionMailer support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4do
commented
Jul 22, 2022
mailtrap.gemspec
Outdated
| @@ -19,6 +19,9 @@ Gem::Specification.new do |spec| | |||
| spec.metadata['changelog_uri'] = 'https://github.com/railsware/mailtrap-ruby/blob/main/CHANGELOG.md' | |||
| spec.metadata['rubygems_mfa_required'] = 'true' | |||
|
|
|||
| spec.add_dependency 'mail' | |||
| spec.add_dependency 'net-smtp' | |||
There was a problem hiding this comment.
This gem is needed as Ruby 3.1 doesn't have 'net/smtp' package included.
mikel/mail#1472
Or should we move this to regular Gemfile since we not require ActionMailer (thus are not using mail in runtime)?
IgorDobryn
approved these changes
Jul 26, 2022
| module Sending | ||
| module Convert | ||
| class << self | ||
| def from_message(message) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity |
There was a problem hiding this comment.
Should we commit code with rubocop:disasble?
There was a problem hiding this comment.
I don't think it's a good idea to liberate rubocop settings for the entire repo having in mind we are talking about a single method with disables.
Any ideas to simplify the code?
r4do
force-pushed
the
add-actionmailer-integration
branch
from
0e9e628 to
02512d9
Compare
leonid-shevtsov
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.