Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license summary #94

Merged
merged 1 commit into from
Feb 28, 2021
Merged

Fix license summary #94

merged 1 commit into from
Feb 28, 2021

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Feb 26, 2021

In #86 I changed the way licenses are handled to allow the --from=all option. That meant however that the license classifier wasn't written into the package metadata anymore if the wasn't any.

This PR uses select_license_by_source to correctly identify which license should be counted.

Closes #93

--

Regarding the dev branch: This should definitely be address there as well. However since the structure changed, a rebase on its own won't do it. I would suggest that I open and additional PR just for it once the dev branch is rebased correctly.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #94 (7b710aa) into master (3c9aab1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files           1        1           
  Lines         380      380           
=======================================
  Hits          376      376           
  Misses          4        4           
Impacted Files Coverage Δ
piplicenses.py 98.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9aab1...7b710aa. Read the comment docs.

@raimon49
Copy link
Owner

@cdce8p @johnthagen Thanks for the report and the correction 👍

@raimon49
Copy link
Owner

Regarding the dev branch: This should definitely be address there as well. However since the structure changed, a rebase on its own won't do it. I would suggest that I open and additional PR just for it once the dev branch is rebased correctly.

Yes, we will.

@raimon49 raimon49 merged commit 2d30942 into raimon49:master Feb 28, 2021
@cdce8p cdce8p deleted the fix-summary branch February 28, 2021 02:01
@cdce8p cdce8p mentioned this pull request Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent default behavior of --summary option
2 participants