Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Points: block read-only wallets from onboarding after deeplinking #5281

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Points: block read-only wallets from onboarding after deeplinking #5281

merged 1 commit into from
Dec 15, 2023

Conversation

benisgold
Copy link
Contributor

Fixes APP-####

What changed (plus any additional context for devs)

  • fix bug that makes it possible for read-only wallets to enter onboarding flow after deeplinking in from a referral link

Screen recordings / screenshots

https://www.loom.com/share/d5004d1751ba4c26b9e58ff4f8819e97

What to test

@benisgold benisgold added release for release blockers and release candidate branches rainbow points labels Dec 15, 2023
jinchung
jinchung approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit 36353e9 into develop Dec 15, 2023
5 of 6 checks passed
@jinchung jinchung deleted the @benisgold/points-block-readonly branch December 15, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchung jinchung jinchung approved these changes

@walmat walmat Awaiting requested review from walmat

@dereknelson dereknelson Awaiting requested review from dereknelson

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

Assignees
No one assigned
Labels
rainbow points release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benisgold @jinchung