NFT sort cleanup #5289

christianbaroni · 2023-12-18T19:48:26Z

What changed (plus any additional context for devs)

Sort UI polish
Enables last sale/floor price for all networks
Now only fetching Reservoir floor price when necessary, as a fallback, to align the floor price in the expanded state with the sorted floor prices

Now using the Reservoir floor price as a fallback, only fetching when necessary

- Highest floor price first - Collections with no floor price are now pushed to the bottom

This reverts commit 0fe50fa.

Was seeing an error in useExternalWalletSectionsData.ts where buildBriefUniqueTokenList was used

walmat

LGTM. Thanks for the cleanup!

christianbaroni added 5 commits December 18, 2023 14:33

Clean up NFT sort UI, list header heights

31d3442

Align expanded state floor price with sort floor price

5630d72

Now using the Reservoir floor price as a fallback, only fetching when necessary

Fix floor price sorting

0fe50fa

- Highest floor price first - Collections with no floor price are now pushed to the bottom

Show last sale/floor price for all networks

aa1009c

Adjust NFT sort mode labels

673bf43

christianbaroni requested review from walmat and benisgold December 18, 2023 19:48

christianbaroni added 3 commits December 18, 2023 14:55

Revert "Fix floor price sorting"

3f07bea

This reverts commit 0fe50fa.

Default to recent sort

684fcae

Was seeing an error in useExternalWalletSectionsData.ts where buildBriefUniqueTokenList was used

Remove isSaleInfoSupported

8662798

walmat approved these changes Dec 19, 2023

View reviewed changes

Lint

cdf8618

christianbaroni merged commit d62e8b5 into develop Dec 19, 2023
5 of 6 checks passed

christianbaroni deleted the @christian/nft-sort branch December 19, 2023 18:31