chore: coin icon refactor #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
reviewed
Feb 24, 2024
| currency: nativeCurrency, | ||
| }), | ||
| { | ||
| staleTime: Infinity, |
There was a problem hiding this comment.
should we cache this response also?
benisgold
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1116
Fixes APP-1095
This is currently waiting for the TX refactor to be merged so we have the necessary data everywhere
What changed (plus any additional context for devs)
replaces the fragmented coin icon components with one source of truth based on BE data vs static cloudinary links
RainbowCoinIcon should be used for all coin icons,
if you need to use ETH i created EthCoinIcon
I'm also readding react-native-fast-image but ONLY for coin icons, this should be little enough usage to not run into the memory issues we were seeing preciously when we were using it everywhere
Screen recordings / screenshots
What to test