NFT expanded state fixes #5761
Merged
NFT expanded state fixes #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
May 23, 2024
walmat
added a commit
that referenced
this pull request
May 24, 2024
* types improvements * useSwapsStore * number & currency formatter * gasss * dont keep previous data * use chainId from input token * hm * decimal separator * add gas fee to review panel * 😕 * save * fix (#5758) * consolidated verified assets fetches (#5759) * fix (#5761) * chore: i18n updates (#5762) * APP-1500 (#5763) * fix * optional chaining just in case * allow message signing tx w/o loaded balance/gas * aaaaaa * uhu * add border back to review gas button * remove color todo tags * gasPrice --------- Co-authored-by: Matthew Wall <[email protected]> Co-authored-by: Ben Goldberg <[email protected]> Co-authored-by: Daniel Sinclair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
some changes i made to the UniqueAsset type caused some issues w/ detecting whether an nft had video/audio/3d model content or not. also caused crashes in some cases
Screen recordings / screenshots
What to test