Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android e2e clean up #5970

Merged
merged 12 commits into from
Aug 27, 2024
Merged

android e2e clean up #5970

merged 12 commits into from
Aug 27, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Jul 30, 2024

TASK: audit Android e2e and see where the blocker is

  • Android detox builds build as expected
  • Tests begin to run
  • Detox app gets stuck on Rainbow splash screen
  • Will debug why later, but this is the current blocker.
  • run adb logcat to see whats up and fix

@BrodyHughes BrodyHughes changed the title android e2e android e2e clean up Aug 5, 2024
Copy link

socket-security bot commented Aug 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/[email protected])

View full report↗︎

@BrodyHughes BrodyHughes marked this pull request as ready for review August 5, 2024 19:30
android/app/build.gradle Outdated Show resolved Hide resolved
@jinchung jinchung removed their request for review August 8, 2024 20:16
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to merge after fixing conflicts.

.detoxrc.js Outdated Show resolved Hide resolved
.github/workflows/macstadium-android-e2e.yml Show resolved Hide resolved
@BrodyHughes BrodyHughes force-pushed the brody/enable-android-tests branch from 014d690 to ac6454b Compare August 27, 2024 18:35
@BrodyHughes BrodyHughes merged commit b13d453 into develop Aug 27, 2024
5 checks passed
@BrodyHughes BrodyHughes deleted the brody/enable-android-tests branch August 27, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants