Wallet Groups #6314
Open
Wallet Groups #6314
+248
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
walmat
reviewed
Dec 11, 2024
bumped this to draft @greg-schrammel. I think it's important that we confirm final design so that reviewers know what they're testing |
…et-group-when-creating-a-wallet
…mpt-user-to-choose-wallet-group-when-creating-a-wallet
greg-schrammel
commented
Dec 20, 2024
walmat
requested review from
derHowie and
maxbbb
and removed request for
benisgold
maxbbb
reviewed
Jan 6, 2025
src/assets/CreateNewWalletGroup.png
Outdated
There was a problem hiding this comment.
Any reason this was needed over the existing CreateNewWallet.png?
There was a problem hiding this comment.
that one has a builtin shadow
src/navigation/ChooseWalletGroup.tsx
Outdated
There was a problem hiding this comment.
The other screens of the AddWalletNavigator are in the screens folder, I'd assume the ChooseWalletGroup sheet should be too.
There was a problem hiding this comment.
yes good call
maxbbb
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
adds ability to choose a mnemonic to derive a new account from (wallet groups)
Screen recordings / screenshots
Screen.Recording.2024-12-20.at.14.58.14.mov
What to test
test you can create new wallet groups, new accounts in these groups, and these wallets actually work (sign something)