Performance improvements #6376
Merged
Performance improvements #6376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when the data changes, search results will always update — fixes a bug where results would occasionally be empty if data only became available after initial mount
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@shopify/[email protected], npm/@tanstack/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
The previous Map structure was resulting in all userAssets stores accessed during runtime being held permanently in memory. On top of that, `useWalletsHiddenBalances` was repeatedly looping through all wallets on app launch, causing every userAssets store to be accessed and thus held in memory. Now, hidden asset balances are summed any time a specific wallet's assets are synced to Zustand, and any time `setHiddenAssets` is called. That total is saved to `userAssetsStoreManager`'s persisted state, allowing all of the user's hidden wallet balances to be read from a single source, with no need to loop through individual stores. The tradeoff here, which I think is acceptable, is that users will temporarily see their hidden balances reflected in each wallet's total balance, until that wallet next fetches assets. That seems benign enough to forgo a migration.
|
Super speedy ⚡ |
|
lgtm |
|
lgtm. 🚢 |
|
lgtm 🤠 |
|
lgtm 🐎 |
| export const persistOptions: Omit<PersistQueryClientOptions, 'queryClient'> = { | ||
| persister: asyncStoragePersister, |
|
lgtm |
brunobar79
reviewed
Jan 9, 2025
`chainBalances.size` will only be zero if `setUserAssets` has never been called for the active store. If `setUserAssets` has been called, `chainBalances` will be populated, regardless of whether the wallet has assets.
The first run of any `useAnimatedStyle` or `useDerivedValue` is executed on the JS thread. The first run can be detected by checking if `_WORKLET` is `false`, which allows bypassing expensive JS thread SV reads if you can set the hook's initial return value through other means. These changes bypass the vast majority of JS thread SV reads throughout the browser, which reduces JS thread blocking post app launch and during browser tab creation.
Prevents tab switch gestures from activating when the browser search UI is open
- Fixes Android device height and safe area determinations, which were previously inconsistent in what was considered part of the safe area vs. part of the device height — this was causing various UI dimensions to be miscalculated, for instance browser tab heights - Provides the `SafeAreaProvider` with `initialWindowMetrics` which on Android prevents layout shift on initial app launch - Sets the bottom bar background to transparent when button navigation isn't being used - Now correctly handling dimensions regardless of whether the device uses button navigation
The gesture blocking isn't needed
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1603
Fixes APP-2249
What changed (plus any additional context for devs)
Memory Management:
useWalletsHiddenBalanceswas looping through all wallets on app launch, causing every userAssets store to be accessed and thus held in memorysetHiddenAssetsis calleduserAssetsStoreManager's persisted state, allowing all hidden wallet balances to be read from a single source, with no need to loop through individual stores or walletsqueryClient:
MMKVPersisterwith an 8s trailing debounce, which seems to be lighter than the old async persistermaxAgeto restrict query cache growthJS thread Shared Value Reads:
_WORKLETisfalse, allowing bypassing these expensive reads if you can set the hook's initial return value through other meansAndroid UI Fixes:
SafeAreaProviderwithinitialWindowMetricswhich on Android prevents layout shift on app launch-Now correctly handling dimensions regardless of whether the device uses button navigation
Package Upgrades:
1.5.10→1.8.23.16.3→3.16.6Additional Changes
Screen recordings / screenshots
What to test