Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dapps query to createQueryStore #6385

Open
wants to merge 3 commits into
base: @christian/remote-rainbow-store
Choose a base branch
from
Open

Migrate dapps query to createQueryStore #6385

wants to merge 3 commits into from
+70 −88

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Migrates the browser dapps query to createQueryStore
  • Removes the need to pull the full dapps object into each homepage Card component

Screen recordings / screenshots

What to test

@christianbaroni christianbaroni added the performance performance related improvements label Jan 6, 2025
@brunobar79
Copy link
Member

Launch in simulator or device for 50a0126

walmat
walmat approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@jinchung jinchung Awaiting requested review from jinchung

@maxbbb maxbbb Awaiting requested review from maxbbb

Assignees
No one assigned
Labels
performance performance related improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christianbaroni @brunobar79 @walmat