Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Urdu for the website #16

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

noob-master147
Copy link
Contributor

@noob-master147 noob-master147 commented Apr 2, 2020

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Checklist

  • Does this PR have a corresponding GitHub issue?
  • Have you added debug messages where necessary?
  • Have you added task comments where necessary?
  • Have you tested the changes for possible failure conditions?
  • Have you tested the UI results in large screen (min screen width 1000px)
  • Have you tested the UI results in mobile view (min screen width 400px)

Special notes for your reviewer:

@rajchandra3 rajchandra3 self-requested a review April 2, 2020 10:21
Copy link
Owner

@rajchandra3 rajchandra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill the PR template with your responses.

@noob-master147
Copy link
Contributor Author

@rajchandra3, I've checked it and since its not a bugFix, so I've left the top list unchecked of the template.

@rajchandra3 rajchandra3 merged commit 1715abe into rajchandra3:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants