Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when item can't be found by specifying elements #132

Merged
merged 2 commits into from
Aug 14, 2021
Merged

Fix when item can't be found by specifying elements #132

merged 2 commits into from
Aug 14, 2021

Conversation

NaturalHokke
Copy link
Contributor 

RWS::Ichiba::Item.search(genreId: 100317, keyword: "4fd3e6fc6e727ce7d42970b4fa00b1ce").count
# => 0

RWS::Ichiba::Item.search(genreId: 100317, keyword: "4fd3e6fc6e727ce7d42970b4fa00b1ce", elements: "itemName").count
# => /bundle/ruby/2.7.0/gems/rakuten_web_service-1.13.0/lib/rakuten_web_service/ichiba/item.rb:21:in `block in <class:Item>': undefined method `map' for nil:NilClass (NoMethodError)

satoryu
satoryu reviewed Aug 12, 2021
View reviewed changes
Copy link
Member

@satoryu satoryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request.
Could you add a test to check this behavior?

@NaturalHokke
Copy link
Contributor Author

Add test. OK?

@satoryu satoryu merged commit 789b918 into rakuten-ws:master Aug 14, 2021
@NaturalHokke NaturalHokke deleted the fix-ichiba-item-none branch August 15, 2021 02:23
@NaturalHokke
Copy link
Contributor Author

@satoryu please, new version release. 🙇

@satoryu
Copy link
Member

satoryu commented Sep 2, 2021

@NaturalHokke Sorry for late release. I've just released new version v1.13.1 including this fix 🎉
Please try it!

@NaturalHokke
Copy link
Contributor Author

Thank you !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoryu satoryu satoryu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NaturalHokke @satoryu