Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime dependencies net/http #67

Merged
merged 3 commits into from
Jan 22, 2017
+1 −0
Merged

Add runtime dependencies net/http #67

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07f4fe3
Add runtime dependencies net/http
gouf Jan 22, 2017
0a34d73
Remove redundant gem requirement
gouf Jan 22, 2017
3ba6177
Move net/http require to client.rb
gouf Jan 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rakuten_web_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module RakutenWebService; end
RWS = RakutenWebService

require 'net/http'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実際にnet/httpを利用するのは、RWS::Client 内なので、lib/rakuten_web_service/client.rb に移した方が関係が明確になって良いかと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

はい、ではそのように変更します！

require 'rakuten_web_service/ichiba'
require 'rakuten_web_service/books'
require 'rakuten_web_service/kobo'
Expand Down
2 changes: 2 additions & 0 deletions rakuten_web_service.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]
spec.required_ruby_version = '>= 2.1.0'

spec.add_runtime_dependency 'net'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これはTwitter関連のgemだと思うのですが、必要なんでしょうか？

https://rubygems.org/gems/net

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、これは余計な追加でした


spec.add_development_dependency "bundler", "~> 1.3"
spec.add_development_dependency "rake"
spec.add_development_dependency "webmock", "~> 1.20.4"
Expand Down