Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies and tidying modules #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating dependencies and tidying modules #2

wants to merge 1 commit into from

Conversation

kenshaw
Copy link

@kenshaw kenshaw commented May 1, 2021

This removes unused package dependenices declared in the go.{mod,sum}
files, and updates all dependencies.

This removes unused package dependenices declared in the go.{mod,sum}
files, and updates all dependencies.
@kenshaw
Copy link
Author

kenshaw commented May 1, 2021

Hi, @rakyll really appreciate the work done on this driver!

I'm submitting this PR since there are some dependencies listed in go.{mod,sum} that are unnecessary. The usql project incorporates this driver. The extra declared dependency to gorm causes some issues with also incorporating the go-sqlite3 driver.

@skuruppu
Copy link
Collaborator

@kenshaw I don't think @rakyll works on this project anymore. We're continuing the work in https://github.com/cloudspannerecosystem/go-sql-spanner. Would you be able to make this PR against that repo? Then we can review and merge it in. Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants