Remove deprecated API #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfstx
force-pushed
the
remove-deprecated-api
branch
from
414ec10 to
20a51f8
Compare
As reported in #77, the reference from the static fields in `JsonValue` to static fields in `Json` can lead to deadlocks during class initialization. Since this API has only been added for compatibility, the easiest fix seems to be to remove the deprecated fields in `JsonValue`. Use this opportunity to remove all deprecated API for 0.9.5. This commit should fix #77.
ralfstx
force-pushed
the
remove-deprecated-api
branch
from
20a51f8 to
183f266
Compare
|
Considering the amount of breakage even in our own code (still using deprecated API in the performancetest project), I suppose that removing all deprecated API in 0.9.5 would likely break too many projects out there. Also, it turned out that #77 should be fixed already in 0.9.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #77, the reference from the static fields in
JsonValueto static fields in
Jsoncan lead to deadlocks during classinitialization.
Since this API has only been added for compatibility, the easiest fix
seems to be to remove the deprecated fields in
JsonValue.Use this opportunity to remove all deprecated API for 0.9.5.
This commit should fix #77.