fix(fzf-lua): respect flat background config and set backdrop #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The gutter cannot be made transparent via a highlight group. The issue is explained and I'm currently considering my workaround here: ibhagwan/fzf-lua#1306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some kind of bug where if I switch colorset via CLI, it will not apply backdrop to background. That is fixed when
FzfLuaBackdropgroup is set explicitly. I used this opportunity to customize the backdrop as well.Something should be done about
lazybackdrop as well (so it matches this backdrop), butlazydoes not have a highlight group for this. Should we start modifying plugin configs? It would definitely allow for a more uniform UI, but might be a bit of an overtake.