-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fromStrictString method #533
base: 4.x
Are you sure you want to change the base?
Conversation
Hi @ramsey, looks like there is a python issue on the docs build step. Could you review it? thanks! |
* | ||
* @psalm-pure | ||
*/ | ||
public function fromStrictString(string $uuid): UuidInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interface changes will require a major version bump.
@rogervila Thanks for the PR. Unfortunately, I'm unemployed without any income, and I'm spending every waking minute on job searching, so I'll be unable to give this much attention until I've sorted out my financial situation. Thank you for your understanding. 🙂 |
Co-authored-by: Ben Ramsey <[email protected]>
Don't worry, first things first 🙂 |
Can you provide some more details on when a user might use Another problem is the introduction of a new interface method. This breaks BC and would need to wait until a later major version of this library. |
Description
Provide a new fromStrictString method that validates the string against the isValid method.
Motivation and context
Fix #531
How has this been tested?
The new method is covered by Unit tests.
Types of changes
PR checklist