Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync gh pages #2

Merged
merged 18 commits into from
Aug 15, 2018
Merged

sync gh pages #2

merged 18 commits into from
Aug 15, 2018

Conversation

ramybenaroya
Copy link
Owner

Thanks for taking the effort to create a PR!

If you are creating an extensive PR, you might want to open an issue with your idea first, so that you don't put a lot of effort in an PR that wouldn't be accepted. Please prepend pull requests with WIP: if they are not yet finished
PR checklist:

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Feel free to ask help with any of these boxes!

The above process doesn't apply to doc updates etc.

ChrisFan and others added 18 commits July 2, 2018 18:41
isolatedGlobalState ==> isolateGlobalState
Remove old api functionality from docs
Warn against decorating @action.bound on componentWillUnmount()
On line 66, changed "that *both* all these" to "that all these".
The paragraph seemed to be missing parts of a sentence
describing the first argument given to the effect function.
This commit rewords the paragraph somewhat to describe
the first argument.
docs: Reword the effect function paragraph
Add missing words.  (I assume that my guesses are correct; maybe they're not!)
@ramybenaroya ramybenaroya merged commit ba941b8 into ramybenaroya:gh-pages Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants