Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bootstrap delegation #14

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Conversation

anmazzotti
Copy link
Collaborator

Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (ad2962a) 49.00% compared to head (e8b2e8d) 56.06%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/controller/elementalmachine_controller.go 71.30% 31 Missing and 2 partials ⚠️
internal/agent/plugin/elemental/elemental.go 62.50% 18 Missing and 9 partials ⚠️
cmd/agent/main.go 87.11% 17 Missing and 4 partials ⚠️
internal/agent/plugin/dummy/dummy.go 35.71% 12 Missing and 6 partials ⚠️
internal/controller/elementalcluster_controller.go 74.54% 13 Missing and 1 partial ⚠️
internal/api/types.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   49.00%   56.06%   +7.05%     
==========================================
  Files          38       38              
  Lines        3028     3412     +384     
==========================================
+ Hits         1484     1913     +429     
+ Misses       1317     1259      -58     
- Partials      227      240      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
Signed-off-by: Andrea Mazzotti <[email protected]>
@anmazzotti anmazzotti marked this pull request as ready for review December 12, 2023 13:46
@anmazzotti anmazzotti merged commit 8056176 into main Dec 12, 2023
10 checks passed
@anmazzotti anmazzotti deleted the delegate-bootstrap-to-plugin-2 branch December 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elemental CAPI bootstrap application
1 participant