Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
This adds more display information:
Note that there is a sneaky change too.
The
machine-name
label used on hosts now reflects the CAPI Machine name, and not the ElementalMachine name as previously.Functionally this does not have any effect, the controller only checks whether the label exists when finding host candidates, the value does not matter.
Since the ElementalMachine is already referenced in the Host spec, I thought it would be nice to use the machine-name label to propagate the CAPI machine name instead.