Prevent associating multiple ElementalHosts #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props to @juadk for finding this corner case.
For context, the ElementalMachine <--> ElementalHost association works like the following, from the ElementalMachineController perspective:
It can happen that 2. fails after 1. succeeds, this will lead to another ElementalMachine reconcile loop, where we are going to find a new ElementalHost. The one already linked is going to be excluded from a followup search, since it's already labeled as associated.
It will look like this, where the same ElementalMachine is associated to 2 (or more) ElementalHosts:
This patch introduces a prior lookup to find any already-linked ElementalHost, and use it as a candidate to finalize association.