Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create initial UI to display the diagnostics #2656

Closed
1 task
Tracked by #2319
jandubois opened this issue Jul 29, 2022 · 4 comments · Fixed by #2767
Closed
1 task
Tracked by #2319

Create initial UI to display the diagnostics #2656

jandubois opened this issue Jul 29, 2022 · 4 comments · Fixed by #2767

Comments

@jandubois
Copy link
Member

jandubois commented Jul 29, 2022

We already have some designs from Manuele; just adding my old notes here:

General

  • Diagnostics are displayed in their own tab. The tab label gets a batch with the number of failed checks.

  • The tab displays only failed checks that have not been muted. Each failed test has a checkbox that can be used to mute this check in the future.

  • A checkbox to display "all" checked (including passed and muted ones).

  • A button to "Refresh" all checks (in case the user fixed a configuration problem manually outside the app). It should show approximately when the diagnostics were last refreshed (e.g. 1 minutes ago, 5 minutes ago, 2 days ago).

  • A button to "Unmute" all muted checks.

  • An indicator of the number of muted failed checks.

List of checks

  • Checks are grouped by category

  • Each check has a pass/fail indicator and a mute checkbox.

  • Each check has 0 or more "fix actions" below it; fix actions may have a button to invoke a callback. The callback may update the diagnostics object in arbitrary ways (add more checks, change pass/fail of existing checks).

  • [diagnostics] Remove @ts-ignore for BadgeState import

Designs

https://xd.adobe.com/view/5a2be601-740a-41bc-8908-ec4da5208ffd-0f78/

@gaktive
Copy link
Contributor

gaktive commented Jul 29, 2022

@rak-phillip to work with Manuele based on his proposed wireframes and add screenshots.

@gaktive
Copy link
Contributor

gaktive commented Jul 29, 2022

Proposed wireframe: https://xd.adobe.com/view/7e428229-357f-4b58-8761-badb84e4a107-2b11/
Need to incorporate categorizations for checks but it should be a minor revision.

@gaktive
Copy link
Contributor

gaktive commented Aug 5, 2022

@manuelecarlini now added to the repo.

@rak-phillip
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants