Create template for Diagnostics #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
src/layouts/default.vue
Outdated
| '/PortForwarding', | ||
| '/Images', | ||
| '/Troubleshooting', | ||
| const routes = [ |
There was a problem hiding this comment.
I would feel better if this object didn't have the same name as the enclosing method (I know it's allowed, but I think we can be clearer). Maybe routeTable instead of routes?
There was a problem hiding this comment.
I think that's a fair assessment, fixed with your suggestion 🙂
ericpromislow
requested changes
Aug 12, 2022
Signed-off-by: Phillip Rak <[email protected]>
ericpromislow
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a simple template for Diagnostics with a few hard-coded examples for testing.
We are missing a few elements that are represented in the design, most notably the mute toggle. I made the decision to leave this out for the time being. My preference is to get
ToggleSwitch.vuepublished in@rancher/components. If this proves to be taking too long, we can simply copy the component over like we do with other Dashboard components.Diagnostics is accessed by the
RD_ENV_DIAGNOSTICSenvironment variable that functions as a feature flag. You can test the template with:Examples
contributes to #2656