Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdctl: use of navPage.progressBecomesReady looks incorrect #5368

Closed
ericpromislow opened this issue Aug 18, 2023 · 0 comments · Fixed by #5369
Closed

rdctl: use of navPage.progressBecomesReady looks incorrect #5368

ericpromislow opened this issue Aug 18, 2023 · 0 comments · Fixed by #5369
Labels
kind/bug Something isn't working

Comments

@ericpromislow
Copy link
Contributor

ericpromislow commented Aug 18, 2023 •
edited
Loading

Actual Behavior

Sometimes the e2e rdctl test at line 855 ('accepts new settings') fails, and emits about 100 locator-related error messages.

It looks like we have a race condition: the call to waitForRestartVM verifies that the progress bar is visible, and then when it returns we make another call to navePage.progressBecomesReady that verifies that the progress bar is visible (but it might not be anymore).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using the same locator in the test removes the race condition. rancher-sandbox/rancher-desktop
1 participant
@ericpromislow