Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the same locator in the test removes the race condition. #5369

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Using the same locator in the test removes the race condition. #5369

merged 1 commit into from
Aug 22, 2023

Conversation

ericpromislow
Copy link
Contributor

Fixes #5368

@mook-as mook-as self-requested a review August 21, 2023 18:09
mook-as
mook-as approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@mook-as mook-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's kinda okay, but really we should be looking at #1217 (as mentioned in the progressBecomesReady implementation) instead, especially with waitForRestartVM being a thing.

@ericpromislow ericpromislow merged commit e4d7eb7 into main Aug 22, 2023
@ericpromislow ericpromislow deleted the 5368-remove-rdctl-e2e-race-condition branch August 22, 2023 16:57
@ericpromislow
Copy link
Contributor Author

rdctl status has been talked about for a long time.

For testing, I'd like to be able to get the last N statuses with timestamps, and a way to get the current timestamp for purposes of synchronization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mook-as mook-as mook-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rdctl: use of navPage.progressBecomesReady looks incorrect
2 participants
@ericpromislow @mook-as