Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers/auto-start BATS test fails on macOS with 1.15.0 release build #7337

Closed
jandubois opened this issue Aug 10, 2024 · 3 comments
Closed
Labels
kind/bug Something isn't working platform/macos regression Functionality was working in a previous release and is now broken triage/patch-candidate

Comments

@jandubois
Copy link
Member

I'm pretty sure this worked for me in RC testing, but now fails repeatedly on both macOS Sonoma (Intel) and Sequoia Beta (Arm):

 ✗ Verify that the auto-start config is created
   (from function `assert_file_exists' in file bats-file/src/file.bash, line 72,
    in test file tests/containers/auto-start.bats, line 42)
     `assert_file_exists "$HOME/Library/LaunchAgents/io.rancherdesktop.autostart.plist"' failed

   -- file does not exist --
   path : /Users/jan/Library/LaunchAgents/io.rancherdesktop.autostart.plist
   --

Same thing happens when I set the autostart option manually via either rdctl or the preferences dialog: it never creates the autostart plist file.

@jandubois jandubois added kind/bug Something isn't working platform/macos triage/patch-candidate regression Functionality was working in a previous release and is now broken labels Aug 10, 2024
@mook-as
Copy link
Contributor

mook-as commented Aug 12, 2024

That test appears to have succeeded in https://github.com/rancher-sandbox/rancher-desktop/actions/runs/10316095503/job/28591674676, https://github.com/rancher-sandbox/rancher-desktop/actions/runs/10298581142/job/28504046163 and https://github.com/rancher-sandbox/rancher-desktop/actions/runs/10298581142/job/28504046990 (all failed later in the suite).

However, I can replicate the issue.

I think it's because my path management rewrite screwed up and threw an exception in enforce(), so it never got to the point where runRdctlSetup() was invoked:

await pathManager.enforce();
if (newSettings.application.hideNotificationIcon) {
Tray.getInstance(cfg).hide();
} else {
if (firstRunDialogComplete) {
Tray.getInstance(cfg).show();
}
mainEvents.emit('k8s-check-state', k8smanager);
}
await runRdctlSetup(newSettings);
window.send('preferences/changed');

2024-08-12T18:11:28.901Z: UnhandledRejectionWarning: Error: Refusing to manage …/.bashrc which has extended attributes
    at Kn (…/dist/app/background.js:41:63137)
    at async Promise.all (index 0)
    at async …/dist/app/background.js:41:65550

@mook-as
Copy link
Contributor

mook-as commented Aug 12, 2024

Note that this was already fixed in #7297 (we catch any errors and report it instead of passing it up) but that's not in the release-1.15 branch.

@mook-as
Copy link
Contributor

mook-as commented Aug 12, 2024

Resolved with #7340 on release-1.15, and #7297 in main.

@mook-as mook-as closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working platform/macos regression Functionality was working in a previous release and is now broken triage/patch-candidate
Projects
None yet
Development

No branches or pull requests

2 participants