Pick Diagnostics: path management onto release-1.15 #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for a diagnostics checker to return multiple results; this will be used for the path management diagnostics. Signed-off-by: Mark Yen <[email protected]>
This actually just stores the result from the last path management run in memory, and report that when requested. Signed-off-by: Mark Yen <[email protected]>
Update `manageLinesInFile` to throw unique errors so that the diagnostics has more information with which to provide better fix suggestions. Signed-off-by: Mark Yen <[email protected]>
Signed-off-by: Mark Yen <[email protected]>
The `kubeConfigSymlink` checker only makes sense on Windows. Signed-off-by: Mark Yen <[email protected]>
Also drops one line of excess logging. Signed-off-by: Mark Yen <[email protected]>
Nino-K
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges #7297 ("Diagnostics: path management") onto the release-1.15 branch.
From the original pull request description: