Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL: Integrations: use marker #5801

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

mook-as
Copy link
Contributor

@mook-as mook-as commented Oct 20, 2023

  • Rather than checking to see if the kubeconfig is a symlink, determine if integration is set up in a distro by writing a file to the root directory to ensure that we do the correct thing if kubernetes is disabled (also, because we need to change how kubeconfig management works).
  • Re-organize how we do the integrations so we can always set the flag file after everything else.

- Rather than checking to see if the kubeconfig is a symlink, determine if
  integration is set up in a distro by writing a file to the root directory
  to ensure that we do the correct thing if kubernetes is disabled (also,
  because we need to change how kubeconfig management works).
- Re-organize how we do the integrations so we can always set the flag file
  after everything else.

Signed-off-by: Mark Yen <[email protected]>
@mook-as mook-as requested a review from Nino-K October 20, 2023 01:02
@mook-as
Copy link
Contributor Author

mook-as commented Oct 20, 2023

Note: Please use rdctl api /v1/settings --body '{"WSL": {"integrations": { … } } }' to test this due to #5805.

@Nino-K Nino-K merged commit 227c504 into rancher-sandbox:main Oct 20, 2023
@mook-as mook-as deleted the wsl/integration-flag-file branch October 25, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants